Re: BUG #7836: COPY command does not honor 'FORMAT' option

On Tue, Jan 29, 2013 at 05:52:16PM -0500, Tom Lane wrote:
> Jeff Janes <jeff.janes@gmail.com> writes:
> > I figured out the need for the parenthesis by reading the docs.  The
> > need to also quote 'binary' really took me by surprise, especially as
> > the other two formats don't need to be quoted.  I assume the reason
> > for this is the level of reservedness of the various words in bison.
>
> Yeah, BINARY is a type_func_name_keyword and hence not covered by the
> copy_generic_opt_arg production.
>
> > But is this a doc bug?  Should <literal>binary</literal> be shown
> > quoted if it needs to be used quote?  Or at least maybe the Example
> > section could include an example of the use of FORMAT.
>
> Probably better to see if we can fix the grammar instead of documenting
> a klugy workaround.  I'm not sure we can easily allow fully-reserved
> words there, but type_func_name_keyword might work.

FYI, the need for single-quotes around 'binary' was removed with a patch
and backpatched.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +