Re: warning in code while building on windows

Andrew Dunstan escribió:
> 
> On 08/18/2013 05:08 PM, Alvaro Herrera wrote:
> >Amit Kapila escribió:
> >>1>.\src\backend\utils\cache\relfilenodemap.c(213) : warning C4101:
> >>'isnull' : unreferenced local variable
> >>
> >>It seems this variable is used only under macro USE_ASSERT_CHECKING,
> >>so it is better to declare under this macro only.
> >We have a macro for this, PG_USED_FOR_ASSERTS_ONLY.  This should silence
> >it; if the msvc stuff is not picking it up then maybe we need to tweak
> >the definition of the macro somehow.
> 
> The macro is pretty gcc-specific, isn't it?
> 
> For MSVC we would probably need to surround the declaration with
> something like these lines.
> 
>    #pragma warning(disable:4101)
>    #pragma warning(default:4101)

That seems pretty difficult to do with the position we've chosen for the
macro.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services