Re: pgsql: Move Assert() definitions to c.h

Tom Lane wrote:
> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> > Tom Lane wrote:
> >> This seems a bit odd.  Why didn't you move all of postgres.h's section 3
> >> into the new section in c.h?  The couple of declarations you left there
> >> are neither useful nor intelligible on their own.
>
> > One slight problem in this line:
>
> > extern PGDLLIMPORT bool assert_enabled;
>
> > This appears in line 622 in c.h, but PGDLLIMPORT is not defined till
> > line 965.  So we would have to put that declaration below section 9
> > "system specific hacks".  Having a separate
> > #if defined(USE_ASSERT_CHECKING) && !defined(FRONTEND)
> > section seems weird.
>
> Ah.  Okay, let's leave it alone then.  It might be worth adding a
> comment though that says these declarations are support for the
> Assert-related macros in c.h.

Fixed; I did move the other declaration to c.h.

--
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services