Re: [PATCH 4/5] Add pg_xlogdump contrib module

Andres Freund wrote:
> On 2013-02-04 13:22:26 -0300, Alvaro Herrera wrote:

> > +typedef struct RmgrDescData
> > +{
> > +    void        (*rm_desc) (StringInfo buf, uint8 xl_info, char *rec);
> > +} RmgrDescData;
> > +
> > +extern const RmgrDescData RmgrDescTable[];
> > +
>
> I think we would at least need to include rm_name here as well.

Not rm_name (that would be duplicative), but a comment with the name of
each rmgr's name in its line should be sufficient.

--
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services