Re: CF3+4 (was Re: Parallel query execution)

On Mon, Jan 21, 2013 at 02:04:14PM -0500, Tom Lane wrote:
> Josh Berkus <josh@agliodbs.com> writes:
> >> IMHO that's the single most important task of a review.
> 
> > Really?  I'd say the most important task for a review is "does the patch
> > do what it says it does?".  That is, if the patch is supposed to
> > implement feature X, does it actually?  If it's a performance patch,
> > does performance actually improve?
> 
> > If the patch doesn't implement what it's supposed to, who cares what the
> > code looks like?
> 
> But even before that, you have to ask whether what it's supposed to do
> is something we want.

Yep.  Our TODO list has a pretty short summary of this at the top:
       Desirability -> Design -> Implement -> Test -> Review -> Commit

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + It's impossible for everything to be true. +