Re: erroneous restore into pg_catalog schema

Tom Lane escribió:
> "Erik Rijkers" <er@xs4all.nl> writes:
> > On Sun, January 13, 2013 22:09, Tom Lane wrote:
> >> BTW, although Erik claimed this behaved more sanely in 9.2, a closer
> >> look at the commit logs says that the bogus commit shipped in 9.2,
> >> so AFAICS it's broken there too.
>
> > [ not so ]
>
> Hm, you are right, there's another problem that's independent of
> search_path.  In 9.2,
>
> regression=# create table pg_catalog.t(f1 int);
> ERROR:  permission denied to create "pg_catalog.t"
> DETAIL:  System catalog modifications are currently disallowed.
>
> but HEAD is missing that error check:
>
> regression=# create table pg_catalog.t(f1 int);
> CREATE TABLE
>
> I will bet that this is more breakage from the DDL-code refactoring that
> has been going on.  I am getting closer and closer to wanting that
> reverted.  KaiGai-san seems to have been throwing out lots of special
> cases that were there for good reasons.

Isn't this just a475c6036?

--
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services