Re: pgsql: In pg_upgrade, copy fsm, vm, and extent files by checking for fi

On Wed, Nov 14, 2012 at 06:57:13PM -0500, Tom Lane wrote:
> BTW, this patch isn't looking so good on Windows.  Buildfarm member
> chough says
>
> "C:\prog\bf\root\HEAD\pgsql.11252\pgsql.sln" (default target) (1) ->
> (contrib\pg_upgrade target) ->
>   .\contrib\pg_upgrade\relfilenode.c(202): warning C4003: not enough actual parameters for macro 'open'
>
>
> "C:\prog\bf\root\HEAD\pgsql.11252\pgsql.sln" (default target) (1) ->
> (contrib\pg_upgrade target) ->
>   .\contrib\pg_upgrade\relfilenode.c(202): error C2059: syntax error : ')'
>   .\contrib\pg_upgrade\relfilenode.c(207): error C2181: illegal else without matching if
>   .\contrib\pg_upgrade\relfilenode.c(242): error C2059: syntax error : 'return'
>   .\contrib\pg_upgrade\relfilenode.c(243): error C2059: syntax error : '}'
>
>     1 Warning(s)
>     4 Error(s)

OK, fixed by adding a third open() parameter of 0.  I see our other code
does this too.  I am not sure what those syntax errors are but I am
guessing the failed macro messed them up.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +