Re: BUG #6510: A simple prompt is displayed using wrong charset
От | Noah Misch |
---|---|
Тема | Re: BUG #6510: A simple prompt is displayed using wrong charset |
Дата | |
Msg-id | 20121015094818.GB4627@tornado.leadboat.com обсуждение исходный текст |
Ответ на | Re: BUG #6510: A simple prompt is displayed using wrong charset (Tom Lane <tgl@sss.pgh.pa.us>) |
Список | pgsql-bugs |
On Sun, Oct 14, 2012 at 12:10:42PM -0400, Tom Lane wrote: > Alexander Law <exclusion@gmail.com> writes: > > > +#ifdef WIN32 > > + termin = fopen("CONIN$", "r"); > > + termout = fopen("CONOUT$", "w+"); > > +#else > > termin = fopen(DEVTTY, "r"); > > termout = fopen(DEVTTY, "w"); > > +#endif > > if (!termin || !termout > > My immediate reaction to this patch is "that's a horrible kluge, why > shouldn't we change the definition of DEVTTY instead?" You could make DEVTTY_IN, DEVTTY_IN_MODE, DEVTTY_OUT and DEVTTY_OUT_MODE to capture all the differences. That doesn't strike me as an improvement, and no other function would use them at present. As I explained in my reply to Alexander, we should instead remove DEVTTY. > Is there a > similar issue in other places where we use DEVTTY? Yes. However, the other use of DEVTTY arises only with readline support, not typical of native Windows builds. > Also, why did you change the termout output mode, is that important > or just randomness? It's essential: http://archives.postgresql.org/message-id/20121010110555.GA21405@tornado.leadboat.com nm
В списке pgsql-bugs по дате отправления: