Re: FATAL: bogus data in lock file "postmaster.pid": ""

On Wed, Aug 29, 2012 at 12:56:26AM -0400, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > On Wed, Aug 29, 2012 at 12:24:26AM -0400, Alvaro Herrera wrote:
> >> It's a pretty strange line wrap you got in this version of the patch.
> >> Normally we just let the string run past the 78 char limit, without
> >> cutting it in any way.  And moving the start of the string to the line
> >> following "errhint(" looks very odd to me.
>
> > OK, updated patch attached.
>
> I agree with Alvaro's complaint that moving the whole string literal to
> the next line isn't conformant to our usual coding style.  Definitely
> nitpicky, but why would you do it like that?

I remember now why I added "\n".  I am used to writing pg_upgrade output
strings, which are obviously not sent to log files.  Seems I forgot that
distinction.  As far as moving the string to the next line, I was trying
to keep the line from getting too long.

Updated patch has everyone on the same line.  I am fine with nitpicky.
Frankly, I have applied so many patches in the past few weeks, I am glad
someone is watching.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +