Re: Support for XLogRecPtr in expand_fmt_string?

On Fri, Jul 13, 2012 at 10:34:35PM +0300, Peter Eisentraut wrote:
> On tor, 2012-07-12 at 10:13 +0300, Heikki Linnakangas wrote:
> > One idea would be to use a macro, like this:
> > 
> > #define XLOGRECPTR_FMT_ARGS(recptr) (uint32) ((recptr) >> 32),
> > (uint32) 
> > (recptr)
> > 
> > elog(LOG, "current WAL location is %X/%X",
> > XLOGRECPTR_FMT_ARGS(RecPtr));
> > 
> I would rather get rid of this %X/%X notation.  I know we have all grown
> to like it, but it's always been a workaround.  We're now making the
> move to simplify this whole business by saying, the WAL location is an
> unsigned 64-bit number -- which everyone can understand -- but then why
> is it printed in some funny format?

+1

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + It's impossible for everything to be true. +