Re: pg_tablespace_location() error message

On Tue, Apr 10, 2012 at 05:43:12PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > The new pg_tablespace_location() function added in PG 9.2 to remove the
> > director location from pg_tablespace returns an odd error for '0', which
> > is InvalidOID:
> 
> Well, it's the same "odd error" you'd get for any other bogus OID.
> 
> The way the function is coded, it has no need to look into pg_tablespace
> as such, which is why you don't get something like "no such tablespace".
> We could add such a lookup purely for error detection purposes, but I'm
> not real sure I see the point.
> 
> > Is this OK?  It handles NULL just fine:
> 
> That's a consequence of the function being marked strict; it has nothing
> much to do with anything.

OK, just checking before this function gets into a release.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + It's impossible for everything to be true. +