Re: Online base backup from the hot-standby

> As I suggested in the reply to Simon, I think that the change of FPW
> should be WAL-logged separately from that of HS parameters. ISTM
> packing them in one WAL record makes XLogReportParameters()
> quite confusing. Thought?

I want to confirm the reply of Simon. I think we cannot decide how this
code should be if there is not the reply.


>      if (!shutdown && XLogStandbyInfoActive())
> +    {
>          LogStandbySnapshot(&checkPoint.oldestActiveXid, &checkPoint.nextXid);
> +        XLogReportParameters(REPORT_ON_BACKEND);
> +    }
> 
> Why doesn't the change of FPW need to be WAL-logged when
> shutdown checkpoint is performed? It's helpful to add the comment
> explaining why.

Sure. I update the patch soon.



--------------------------------------------
Jun Ishizuka
NTT Software Corporation
TEL：045-317-7018
E-Mail: ishizuka.jun@po.ntts.co.jp
--------------------------------------------