Re: pg_upgrade automatic testing

Bruce Momjian wrote:
> Bruce Momjian wrote:
> > Tom Lane wrote:
> > > Bruce Momjian <bruce@momjian.us> writes:
> > > > I propose I just remove the 8.4
> > > > test and always allow toast table names not to match --- the oids are
> > > > still checked and are preserved.
> > > 
> > > +1.  You'll still make the check for non-toast tables, of course?
> > 
> > Yes, only toast tables will skip the check.  Proposed patch attached.
> 
> I was wrong. I can check for the version number because the toast file
> name is made to match when pg_upgrade completes on the 9.0+ cluster. 
> Updated patch attached that adds comments and checks for 9.0 instead of
> 8.4.

Applied to head and 9.1.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + It's impossible for everything to be true. +