Re: pg_upgrade defaulting to port 25432

Peter Eisentraut wrote:
> On m?n, 2011-06-27 at 14:34 -0400, Bruce Momjian wrote:
> > Bruce Momjian wrote:
> > > Robert Haas wrote:
> > > > It's easier to read the patches if you do separate changes in separate
> > > > patches.  Anyway, I'm a bit nervous about this hunk:
> > > > 
> > > > +         if (old_cluster.port == DEF_PGUPORT)
> > > > +             pg_log(PG_FATAL, "When checking a live old server, "
> > > > +                    "you must specify the old server's port number.\n");
> > > > 
> > > > Is the implication here that I'm now going to need to specify more
> > > > than 4 command-line options/environment variables for this to work?
> > > 
> > > Yes, we don't inherit PGPORT anymore.  Doing anything else was too
> > > complex to explain in the docs.
> > 
> > But only if you are running --check on a live server.  Otherwise, we
> > will just default to 50432 instead of 5432/PGPORT.
> 
> "When checking a live server, the built-in default port number or the
> value of the environment variable PGPORT is used.  But when performing
> an upgrade, a different port number is used by default, namely 50432,
> which can be overridden XXX [how?]"
> 
> Seems pretty clear to me, as long as that last bit is figured out.

Not sure where you got that text --- I assume that was an old email.  I
decided it was too complex to have PGPORT be honoroed only if there is a
live server, so I just always default to 50432 for both servers, and I
added this error check:
   if (user_opts.check && is_server_running(old_cluster.pgdata))   {       *live_check = true;
+       if (old_cluster.port == DEF_PGUPORT)
+           pg_log(PG_FATAL, "When checking a live old server, "
+                  "you must specify the old server's port number.\n");

OK?

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + It's impossible for everything to be true. +