Re: [v9.2] DROP Reworks Part.0 - 'missing_ok' support of get_object_address
От | Noah Misch |
---|---|
Тема | Re: [v9.2] DROP Reworks Part.0 - 'missing_ok' support of get_object_address |
Дата | |
Msg-id | 20110627185937.GD17537@tornado.leadboat.com обсуждение исходный текст |
Ответ на | Re: [v9.2] DROP Reworks Part.0 - 'missing_ok' support of get_object_address (Robert Haas <robertmhaas@gmail.com>) |
Ответы |
Re: [v9.2] DROP Reworks Part.0 - 'missing_ok' support of get_object_address
|
Список | pgsql-hackers |
On Mon, Jun 27, 2011 at 01:28:30PM -0400, Robert Haas wrote: > On Wed, Jun 22, 2011 at 1:36 PM, Robert Haas <robertmhaas@gmail.com> wrote: > > I agree with you. ?If we had a whole pile of options it might be worth > > having heap_openrv() and heap_openrv_extended() so as not to > > complicate the simple case, but since there's no forseeable need to > > add anything other than missing_ok, my gut is to just add it and call > > it good. > > On further review, my gut is having second thoughts. This patch is an > awful lot smaller and easier to verify correctness if I just mess with > the "try" calls and not the regular ones; and it avoids both > back-patching hazards for us and hoops for third-party loadable > modules that are using the non-try versions of those functions to jump > through. +1. (Note that the function header comments need a few more updates.)
В списке pgsql-hackers по дате отправления: