Re: pgindent

Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
> > On 04/10/2011 12:11 PM, Tom Lane wrote:
> >> What I was a bit surprised by is the volume of changes in wparser_def.c
> >> --- so far as I can see, that file hardly changed since 9.0, so why did
> >> pgindent suddenly whack it around so much?  The other files that changed
> >> a lot are mostly new code so widespread changes are unsurprising.
> 
> > I had a dim and possibly erroneous recollection that was one of the 
> > files we excluded from pgindent runs. If you look at the history it 
> > hasn't been touched by pgindent since the 8.3 run. But the changes to it 
> > all look fairly kosher at first glance.
> 
> Oh, I bet you're right -- see commit
> 97116ca4170b974d734cea364789c389b30e6ce1.  That removed the exclusion
> but I don't see any evidence that Bruce actually pgindent'd it then.

Right.  The fix for that file was some time after the pgindent run and I
didn't want to run just that file.

This is the first time I ever had no pgindent failure/warning messages.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + It's impossible for everything to be true. +