Re: Remove pg_am.amindexnulls?

On Fri, Jan 07, 2011 at 08:08:38PM -0500, Tom Lane wrote:
> Now that GIN can index null items, its amindexnulls flag in pg_am
> really ought to be set true.  However, looking at the usage of that
> column, I wonder whether we shouldn't just delete it instead.  The
> only present usage is a rather convoluted test in CLUSTER to see if
> the index is safely clusterable --- and AFAICS that test has been
> obsoleted anyhow by the later addition of pg_am.amclusterable.
> Anyone against simplifying matters by getting rid of
> pg_am.amindexnulls?

I guess the only potential use for it would be for some kind of am
that *couldn't* index nulls out of the gate.  Might their be such AMs
on the horizon?

Cheers,
David.
-- 
David Fetter <david@fetter.org> http://fetter.org/
Phone: +1 415 235 3778  AIM: dfetter666  Yahoo!: dfetter
Skype: davidfetter      XMPP: david.fetter@gmail.com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate