Re: pg_ctl and port number detection

Bruce Momjian wrote:
> Tom Lane wrote:
> > Actually, if we're going to do this at all, we should do
> > 
> >     pid
> >     datadir
> >     port
> >     socketdir
> >     ... here be dragons ...
> > 
> > so that pg_ctl doesn't have to assume the server is running with a
> > default value of unix_socket_dir.  Not sure what to put in the fourth
> > line on Windows though ... maybe just leave it empty?
> 
> OK, here is a patch that adds the port number and optionally socket
> directory location to postmaster.pid, and modifies pg_ctl to use that
> information.  I throw an error on using Win32 with pre-9.1 servers
> because we can't get the port number from that file.
> 
> This removes some crufty code from pg_ctl and removes dependency on
> serveral user-configurable settings that we added as a work-around.
> 
> This will allow pg_ctl -w to work more reliabily than it did in the
> past.

Applied.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + It's impossible for everything to be true. +