Re: gSoC - ADD MERGE COMMAND - code patch submission

On Sat, Jul 10, 2010 at 09:26:38AM -0700, David Fetter wrote:
> On Sat, Jul 10, 2010 at 11:52:31AM +0200, Andres Freund wrote:
> > On Fri, Jul 09, 2010 at 11:33:04PM -0400, Robert Haas wrote:
> > > On Fri, Jul 9, 2010 at 10:25 PM, Boxuan Zhai <bxzhai2010@gmail.com> wrote:
> > > > Dear All,
> > > >
> > > > This is ZHAI BOXUAN, a student of gSoC 2010. My project is to add merge
> > > > command in postgres.
> > > > There is a more detailed instruction in readme.
> > I would find it helpfull to find a short recap of how you want to
> > handle the various problems (mostly around locking) in the readme.
> >
> > > > Any comments will be highly appreciated.
> > > Is there any chance you can submit this as a single patch file?  Or if
> > > not, can you at least use a zip or tar file instead of a RAR archive?
> > > Ideally the patch would be against CVS HEAD, not 8.4.3.
> >
> > I would also suggest you base your patch either against the git tree
> > or CVS. Currently it does include patches agains generated files like
> > gram.y or kwlist.h which make it harder to see the real changes.
> >
> Please find enclosed a patch against git master as of
> 7b2668159bb4d0f5177a23d05bf7c2ab00bc0d75.  It works up to make, but
> fails on make check.
>
> I'm thinking the docs for INSERT, UPDATE, and DELETE should link to
> the docs for this, as they get written.
>
> Cheers,
> David.

Oops.  Just noticed that there were 56 lines' worth of C++ style
comments, which I've corrected in the enclosed patch, along with some
spelling mistakes, grammar, and gratuitous white space.

Cheers,
David.
--
David Fetter <david@fetter.org> http://fetter.org/
Phone: +1 415 235 3778  AIM: dfetter666  Yahoo!: dfetter
Skype: davidfetter      XMPP: david.fetter@gmail.com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate