Re: LLVM / clang

Peter Eisentraut <peter_e@gmx.net> wrote:

> Some new warnings, however:
> 
> xlog.c:7759:22: warning: self-comparison always results in a constant
> value
>                 max_locks_per_xact != max_locks_per_xact)
>                                    ^
> 
> Looks like a bug.

Ah, it should be compared with the same name field in ControlFile.

Index: src/backend/access/transam/xlog.c
===================================================================
--- src/backend/access/transam/xlog.c    (HEAD)
+++ src/backend/access/transam/xlog.c    (fixed)
@@ -7756,7 +7756,7 @@    if (wal_level != ControlFile->wal_level ||        MaxConnections !=
ControlFile->MaxConnections||        max_prepared_xacts != ControlFile->max_prepared_xacts ||
 
-        max_locks_per_xact != max_locks_per_xact)
+        max_locks_per_xact != ControlFile->max_locks_per_xact)    {        /*         * The change in number of
backendslots doesn't need to be
 



Regards,
---
Takahiro Itagaki
NTT Open Source Software Center