Re: [COMMITTERS] pgsql: Add PGFILEDESC description to Makefiles for all /contrib

Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > All other binaries had such a designation, and all /contrib binaries
> > were missing them.  I assume I was doing cleanup.  You want the icon
> > removed from the backend makefile?
>
> Yes.  I'm prepared to believe that not having the icons set on the
> contrib executables was an oversight.  I'm much less prepared to assume
> that not marking the postgres executable was an oversight.  Again,
> unless you *know* that this change is needed and appropriate, now is
> not the time to be making it, and especially not without discussion.

OK, done with attached patch, and I added a comment about why it is not
labeled.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com
Index: src/backend/Makefile
===================================================================
RCS file: /cvsroot/pgsql/src/backend/Makefile,v
retrieving revision 1.142
diff -c -c -r1.142 Makefile
*** src/backend/Makefile    12 May 2010 11:33:09 -0000    1.142
--- src/backend/Makefile    12 May 2010 21:41:14 -0000
***************
*** 10,16 ****
  #-------------------------------------------------------------------------

  PGFILEDESC = "PostgreSQL Server"
! PGAPPICON=win32

  subdir = src/backend
  top_builddir = ../..
--- 10,17 ----
  #-------------------------------------------------------------------------

  PGFILEDESC = "PostgreSQL Server"
! # it is unclear that this should be labeled as an executable
! #PGAPPICON=win32

  subdir = src/backend
  top_builddir = ../..