Re: [SPAM]Re: Questions about 9.0 release note

Takahiro Itagaki wrote:
>
> "Robert Haas" <robertmhaas@gmail.com> wrote:
>
> > > * (seq_page_cost/(random_page_cost))
> > > * EXCLUDE constraints has no tags to be linked.
> > > * "EXCLUDE constraints" is not indexed from the Index page.
>
> > CREATE TABLE ... CONSTRAINT ... EXCLUDE rather than CREATE TABLE
> > CONSTRAINT ... EXCLUDE.
>
> Here is a patch to fix the documentation.
>
> For exclusion constraints, I added a tag "SQL-CREATETABLE-exclude"
> to <varlistentry> of EXCLUDE in CREATE TABLE documentation. Also,
> "Exclusion constraints" section is added to the constraints doc.
> But the section is very short and just links to the CREATE TABLE doc.
> We could move some contents from CREATE TABLE to the constraints doc.

I applied a clarified version of your submitted patch, attached.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com
Index: doc/src/sgml/backup.sgml
===================================================================
RCS file: /cvsroot/pgsql/doc/src/sgml/backup.sgml,v
retrieving revision 2.144
diff -c -c -r2.144 backup.sgml
*** doc/src/sgml/backup.sgml    22 Feb 2010 17:15:10 -0000    2.144
--- doc/src/sgml/backup.sgml    31 Mar 2010 23:34:20 -0000
***************
*** 604,614 ****
      directory).
      It is advisable to test your proposed archive command to ensure that it
      indeed does not overwrite an existing file, <emphasis>and that it returns
!     nonzero status in this case</>.  We have found that <literal>cp -i</> does
!     this correctly on some platforms but not others.  If the chosen command
!     does not itself handle this case correctly, you should add a command
!     to test for existence of the archive file.  For example, something
!     like:
  <programlisting>
  archive_command = 'test ! -f .../%f && cp %p .../%f'
  </programlisting>
--- 604,615 ----
      directory).
      It is advisable to test your proposed archive command to ensure that it
      indeed does not overwrite an existing file, <emphasis>and that it returns
!     nonzero status in this case</>.  On many Unix platforms, <command>cp
!     -i</> causes copy to prompt before overwriting a file, and
!     <literal>< /dev/null</> causes the prompt (and overwriting) to
!     fail.  If your platform does not support this behavior, you should
!     add a command to test for the existence of the archive file.  For
!     example, something like:
  <programlisting>
  archive_command = 'test ! -f .../%f && cp %p .../%f'
  </programlisting>