Michael Paquier <michael.paquier@gmail.com> wrote:
> Please find attached the latest version of the patch,
> with the threading bug corrected and the documentation updated as well.
Why do you use BUFFER_SIZE-1 for snprintf? snprintf(commandShell, SHELL_COMMAND_SIZE-1, ...)
Trailing nulls are also included in the length, so snprintf(commandShell, SHELL_COMMAND_SIZE, ...)
would be ok. (removed -1)
Other parts look fine, except an empty tag <replaceable></> in the
documentation. Is it a typo?
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center