Re: [PATCH] 8.5 TODO: Add comments to output indicating version of pg_dump and of the database server

Jim Cox wrote:
> On Tue, Sep 29, 2009 at 12:00 AM, Alvaro Herrera
> <alvherre@commandprompt.com> wrote:
> > Jim Cox escribi?:
> >
> >> Attached s/b a patch for the 8.5 TODO "Add comments to output indicating version
> >> of pg_dump and of the database server" (pg_dump/pg_restore section, 9.2).
> >
> > Hmm, what happens if you do a pg_dump -Fc? ?Is this info saved anywhere
> > in the dump? ?Surely if thi is useful in the text dump, it is useful in
> > the binary format dumps too.
> 
> (forgot to reply all)
> 
> pg_restore's "-l, --list print summarized TOC of the archive" option
> does display the information in custom format dumps, e.g.:
> 
> prompt$ /usr/local/pgsql/bin/pg_restore -l < /tmp/mytest.dump
> ;
> ; Archive created at Tue Sep 29 13:48:37 2009
> ;     dbname: mytest
> ;     TOC Entries: 9
> ;     Compression: -1
> ;     Dump Version: 1.11-0
> ;     Format: CUSTOM
> ;     Integer: 4 bytes
> ;     Offset: 8 bytes
> ;     Dumped from database version: 8.4.0
> ;     Dumped by pg_dump version: 8.4.0

Are we sure we don't want a date/time in the ASCII dump?  It would
affect database diffs, but I can see it useful too.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +