Re: Savepoints in PgAdmin

Le mardi 1 septembre 2009 à 12:44:08, Dave Page a écrit :
> 2009/8/31 Guillaume Lelarge <guillaume@lelarge.info>:
> > Here is a patch to add this feature. It adds a new setting ("Disable Auto
> > ROOLBACK") in the Query tag of the Options Dialog. This is of course for
> > 1.11.
> >
> > Comments?
>
> ROLLBACK I hope :-)
>

Yes :)

> Looks good - my only comment is whether the option should be to
> disable or enable it. Enable seems cleaner, but of course, disable
> makes sense because it's disabling the current behaviour.
>

Don't know either. My first version of this patch was Enable. But I changed
this to Disable because it was easier this way to write the handling of the
option and to keep the current behavior.

> Magnus - what do you think?

Yes, any comments?


--
Guillaume.http://www.postgresqlfr.orghttp://dalibo.com