Re: Updates of SE-PostgreSQL 8.4devel patches (r1403)

On Wed, Jan 14, 2009 at 09:52:20AM -0500, Tom Lane wrote:
> Martijn van Oosterhout <kleptog@svana.org> writes:
> > On Tue, Jan 13, 2009 at 10:05:45AM -0300, Alvaro Herrera wrote:
> >> pgace.h: you have a bunch of "static inline" functions in here.  As far
> >> as I know this doesn't work in compilers other than GCC :-(
>
> > Really? C99 requires it and MSVC does support it.
>
> Wrong.  What C99 requires is a uselessly cumbersome form of "inline"
> that is not compatible with the GCC feature.  We did actually implement
> C99-compatible inlines in one or two places (in the sorting code IIRC),
> but it's not something that I want to put up with on a large scale.

I was talking about "static inline", where C99 agrees completely with
GCC and is significantly more portable.

Have a nice day,
--
Martijn van Oosterhout   <kleptog@svana.org>   http://svana.org/kleptog/
> Please line up in a tree and maintain the heap invariant while
> boarding. Thank you for flying nlogn airlines.