Re: Significant oversight in that #include-removal script
От | Bruce Momjian |
---|---|
Тема | Re: Significant oversight in that #include-removal script |
Дата | |
Msg-id | 200901072256.n07MuWa05327@momjian.us обсуждение исходный текст |
Ответ на | Re: Significant oversight in that #include-removal script (Tom Lane <tgl@sss.pgh.pa.us>) |
Список | pgsql-hackers |
Tom Lane wrote: > Alvaro Herrera <alvherre@commandprompt.com> writes: > > Bruce Momjian wrote: > >> The script certainly has no way to know it is missing an extern, and I > >> am not sure how I would even teach it that trick. > > > It would be easy if the compiler were to have an option to throw a > > warning when it finds a non-static variable that doesn't have a > > corresponding extern declaration. > > Yeah, I think this is hopeless (or at least not worth the cost) without > compiler support --- I was just idly wondering if newer gcc's might have > such an option. > > The case at hand is actually somewhat improbable, because it requires > having a header file that exports a variable but not any of the file's > functions. So maybe it's not worth worrying about anyway. The only thing I could come up with was to look at the symbols exported by the object files. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. +
В списке pgsql-hackers по дате отправления: