Re: Brittleness in regression test setup

Peter Eisentraut wrote:
> Peter Eisentraut wrote:
>> Alvaro Herrera wrote:
>>> Is it possible to make it retry in case the chosen port is busy?  I
>>> guess a simple check should suffice, ignoring the obvious race condition
>>> that someone uses the port after you checked it was OK.
>>
>> Well, the whole point of this exercise was to avoid that.  If we had a  
>> way to do a "simple check", we might as well stick to the hardcoded 
>> port and count up from that or something.
>
> Well, duh, the checking is actually pretty simple.  We just try to  
> connect with psql to the candidate port number before starting our own  
> postmaster and see if anyone is already there.

But what if something else is using the port?  I think you could attempt
a bare connect().


Note typo here:

> +                    fprintf(stderr, _("Specify an used port using the --port option or shut down any conflicting
PostgreSQLservers.\n"));
 

Should say "an unused port"

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.