Re: pg_do_encoding_conversion glitch

Tom Lane <tgl@sss.pgh.pa.us> wrote:

> Do you have a proposal for a different API, or do you just want to
> improve the comment for the function?  Bear in mind that a lot of the
> callers do know the string length, and so we shouldn't impose an
> unnecessary strlen() operation on those cases.

We already have the following comment, so I think a new comment is
not needed. 
| In the case of no conversion, src is returned.

Since Assert() is not available in the case, developers should use
the function carefully after all. My patch might be fixed, too...
| "Solve a problem of LC_TIME of windows"
| http://archives.postgresql.org/message-id/20081104094301.7EE8.52131E4D@oss.ntt.co.jp

Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center