Re: Updated backslash consistency patch

Greg Sabino Mullane wrote:
> Here's an updated version of the psql backslash patch that should
> apply cleanly to the current HEAD. To recap, this makes all the \dX
> commands (most importantly to most: \df) work like \dt does, in that it
> requires a \dXS to see system items. See the archives for much more
> discussion on the issue.

Some comments:

1. toast objects no longer show up anywhere; they are removed in the
non-system case by excluding pg_toast% schemas, and are removed in the
system case by requiring nspname = 'pg_catalog'

2. the help.c patch no longer applies due to the \dC patch recently
applied

3. the help.c patch breaks alignment of the help output.  I think the
best way to fix it would be to change [PATTERN] into something shorter
like [PAT] and add a mention to that in the first line, something like

>       fprintf(output, _("Informational\n"));
> !      fprintf(output, _("  Modifiers: S = show system objects  + = Additional detail\n"));       fprintf(output, _("
           [PAT] means an optional glob-like pattern\n");
 

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support