Re: pg_regress inputdir

Alvaro Herrera wrote:
> Jorgen Austvik - Sun Norway wrote:
> 
> > Do we also agree that if you set --inputdir to anything other than the  
> > default, pg_regress will not work (will write a file to one folder, and  
> > try to read the same file from another)?
> >
> > And if we agree above - should we make setting --inputdir work (read and  
> > write from/to same directory), remove the --inputdir parameter (since  
> > setting it to anything different from default value doesn't work), or  
> > keep it there (to confuse people)?
> 
> I think the problem here is that you have to set --outputdir too.

Huh, scratch that, I chose a bad test.  create_function_2 obviously fails as
you say:

$ LC_ALL=C /pgsql/build/00head/src/test/regress/pg_regress --inputdir=/pgsql/source/00head/src/test/regress
--srcdir=/pgsql/source/00head/src/test/regress/create_function_2
 
(using postmaster on Unix socket, port 55432)
============== dropping database "regression"         ==============
DROP DATABASE
============== creating database "regression"         ==============
CREATE DATABASE
ALTER DATABASE
============== running regression test queries        ==============
test create_function_2    ... /bin/sh: /pgsql/source/00head/src/test/regress/sql/create_function_2.sql: No such file or
directory
diff: /pgsql/source/00head/src/test/regress/expected/create_function_2.out: No such file or directory
diff: ./results/create_function_2.out: No such file or directory
diff command failed with status 512: diff -w "/pgsql/source/00head/src/test/regress/expected/create_function_2.out"
"./results/create_function_2.out"> "./results/create_function_2.out.diff"
 


I'm not sure if the problem here is --inputdir or --srcdir, or the fact
that we fail to provide a --builddir switch.  In my opinion, the need
for running tests outside the test dir is not very strong (or we would
have heard complaints before), and thus the solution is to remove
--inputdir and --outputdir.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.