Re: float4/float8/int64 passed by value with tsearch fixup

Zoltan Boszormenyi wrote:

>>> So I think we really do need to offer that compile-time option.
>>> Failing to do so will be tantamount to desupporting v0 functions
>>> altogether, which I don't think we're prepared to do.
>>>
>>
>> I have asked the Cybertec guys for a patch.  Since it's basically a copy
>> of the float8 change, it should be easy to do.
>
> Here's the patch (against current CVS) with the required change.
> Please review, it passed make check with both --enable and
> --disable-float4-byval.

Does it pass "make installcheck" in contrib?  I'm worried about
btree_gist in particular.  Perhaps the change I introduced in the
previous revision needs to be #ifdef'd out?

--
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.