Re: Lessons from commit fest

Brendan Jurd wrote:
> >  The idea that we "fix" stylistic issues on the fly is not sustainable.
> >  We should offer help and mentorship to new patch submitters in all
> >  areas (including stylistic) but they should do the work. It is the only
> >  way we will mold them to submit patches in the proper way.
> >
> 
> I agree.  As a submitter I would much rather get an email saying e.g.
> "Hey, your patch is nice but the code style sticks out like a sore
> thumb.  Please adopt surrounding naming convention and fix your
> indentation per the rules at [link]." than have it fixed silently on
> its way to being committed.
> 
> With the former I learn something and get to improve my own work.
> With the latter, my next patch is probably going to have the exact
> same problem, which is in the long term just making extra work for the
> reviewers.

If the patch submitters hasn't read the developers' FAQ, we assume they
are not interested in improving the style of their patch.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +