Re: Cleaner API for appendStringInfoVA
От | Bruce Momjian |
---|---|
Тема | Re: Cleaner API for appendStringInfoVA |
Дата | |
Msg-id | 200803072022.m27KMKE04274@momjian.us обсуждение исходный текст |
Ответ на | Cleaner API for appendStringInfoVA ("Marko Kreen" <markokr@gmail.com>) |
Список | pgsql-patches |
Patch rejected. Sorry. Comment is: The patch of very dubious portability and I'm not even convinced that it'd provide a net performance improvement. --------------------------------------------------------------------------- Marko Kreen wrote: > Attached patch moves decision how much more room to allocate > from callers of appendStringInfoVA to inside the function, > where more info is available. > > On systems with broken vsnprintf() it falls back > to doubleing the buffer. > > Fixme: the +1 could be something larger? Aligned? > > -- > marko [ Attachment, skipping... ] > > ---------------------------(end of broadcast)--------------------------- > TIP 3: Have you checked our extensive FAQ? > > http://www.postgresql.org/docs/faq -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://postgres.enterprisedb.com + If your life is a hard drive, Christ can be your backup. +
В списке pgsql-patches по дате отправления: