Re: buildenv.pl/buildenv.bat
От | Magnus Hagander |
---|---|
Тема | Re: buildenv.pl/buildenv.bat |
Дата | |
Msg-id | 20071205154730.GE7641@svr2.hagander.net обсуждение исходный текст |
Ответ на | Re: buildenv.pl/buildenv.bat (Andrew Dunstan <andrew@dunslane.net>) |
Ответы |
Re: buildenv.pl/buildenv.bat
|
Список | pgsql-hackers |
On Tue, Dec 04, 2007 at 09:31:30AM -0500, Andrew Dunstan wrote: > > > Magnus Hagander wrote: > >>My recollection is that I changed the minimum amount necessary, because > >>I was expecting us to go into beta at anmy moment (silly me). That might > >>be why we still have both. There was an expectation that some cleanup > >>might be required during 8.4 development. I know I left other .bat files > >>as wrappers for the perl scripts, but that's obviously not appropriate > >>here. I'll see if I can adjust builddoc.bat so we can get rid of > >>buildenv.bat. > >> > >>As for documentation, you're probably right, I could easily have missed > >>it. I'll look into it. > >> > > > >Great. Let me know if you need me to poke at anything. > > > > > > > > OK, I'm thinking that the best way might be to do away with buildenv.bat > altogether and replace the remaining references to it in .bat files with > something like this fragment: > > if not exist src\tools\msvc\buildenv.pl goto nobuildenv > perl -e "require 'src/tools/msvc/buildenv.pl'; while(($k,$v) = each > %ENV) { print qq[\@SET $k=$v\n]; }" > tmp.bat > call tmp.bat > del tmp.bat > :nobuildenv > > and adjust the docs accordingly. > > Thoughts? Urgh. I thought you specifically changed the earlier scripts to *avoid* having them create a temporary file and then execute it. Which I agreed with :-) I think I'd prefer we just get rid of the .bat's completely then. I wonder if we are daring enough to do it so late in the cycle, though.. //Magnus
В списке pgsql-hackers по дате отправления: