Re: [HACKERS] install-strip causes dyld errors on OS X

Tom Lane wrote:
> "Meredith L. Patterson" <mlp@osogato.com> writes:
> > In brief, when installing on OS X with "make install-strip",
> > installation goes fine, but initdb dies here:
> > ...
> > I see three possible fixes:
> > 1) Patch config/install-sh such that on OS X, install-strip calls 'strip
> > -x'. This removes local symbols only.
>
> +1 on this one --- seems about the right level of effort, considering
> that install-strip isn't exactly an encouraged option anyway.  (Does
> anyone still care about the amount of disk space involved?  And it makes
> debugging problems infinitely harder.)
>
> Just for the record, I'd like to put forward the alternative solution
> of removing support for install-strip.  But assuming there are
> objections to that, please send in the mentioned 4-line patch ...

I have developed the attached patch to implement this.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://postgres.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +
Index: config/install-sh
===================================================================
RCS file: /cvsroot/pgsql/config/install-sh,v
retrieving revision 1.4
diff -c -c -r1.4 install-sh
*** config/install-sh    11 Mar 2006 04:38:28 -0000    1.4
--- config/install-sh    9 Nov 2007 21:58:23 -0000
***************
*** 56,62 ****
  chmodprog="${CHMODPROG-chmod}"
  chownprog="${CHOWNPROG-chown}"
  chgrpprog="${CHGRPPROG-chgrp}"
! stripprog="${STRIPPROG-strip}"
  rmprog="${RMPROG-rm}"
  mkdirprog="${MKDIRPROG-mkdir}"

--- 56,68 ----
  chmodprog="${CHMODPROG-chmod}"
  chownprog="${CHOWNPROG-chown}"
  chgrpprog="${CHGRPPROG-chgrp}"
! # Darwin normal strip removes symbols from shared libraries
! # that are later needed for dynamic linking, so use strip -x.
! # http://archives.postgresql.org/pgsql-hackers/2007-10/msg01470.php
! if test "$template" = "darwin"
! then    stripprog="${STRIPPROG-strip -x}"
! else    stripprog="${STRIPPROG-strip}"
! fi
  rmprog="${RMPROG-rm}"
  mkdirprog="${MKDIRPROG-mkdir}"