Re: Not *quite* there on ecpg fixes

Andrew Dunstan wrote:
>
>
> Michael Meskes wrote:
>> On Thu, Oct 04, 2007 at 12:47:13AM -0400, Tom Lane wrote:
>>   
>>> Buildfarm member brown_bat (cygwin/gcc) still isn't happy:
>>> ...
>>>     
>>
>> Just committed a patch that hopefully solves this. Kind of surprises me
>> that this only occurs on cygwin.
>
> It's still not working.

It looks like dlltool does not like the .def file:

dllwrap -Wl,--enable-auto-import -o cygpgtypes.dll --dllname cygpgtypes.dll  --def libpgtypesdll.def numeric.o
datetime.ocommon.o dt_common.o timestamp.o interval.o pgstrcasecmp.o   -L../../../../src/port -L/usr/local/lib -lm 
 
dlltool: Syntax error in def file libpgtypesdll.def:3
dlltool: Syntax error in def file libpgtypesdll.def:3
dlltool --dllname cygpgtypes.dll  --def libpgtypesdll.def --output-lib libpgtypes.a
dlltool: Syntax error in def file libpgtypesdll.def:3

Line 3 of that file is unadorned "EXPORTS":

echo '; DEF file for MS VC++' > libpgtypesdll.def
echo 'LIBRARY LIBPGTYPES' >> libpgtypesdll.def
echo 'EXPORTS' >> libpgtypesdll.def


The error that actually finishes the build is below:

gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Winline -Wdeclaration-after-statement -Wendif-labels
-fno-strict-aliasing-g   -I../include -I../../../../src/interfaces/ecpg/include -I../../../../src/interfaces/libpq
-I../../../../src/port-I../../../../src/include  -DBUILDING_DLL  -c -o thread.o thread.c
 
dllwrap -Wl,--enable-auto-import -o cygecpg.dll --dllname cygecpg.dll  --def libecpgdll.def execute.o typename.o
descriptor.odata.o error.o prepare.o memory.o connect.o misc.o path.o  thread.o -L../pgtypeslib
-L../../../../src/interfaces/libpq-L../../../../src/port -L/usr/local/lib -lpgtypes -lpq -lm 
 
execute.o: In function `ecpg_store_input':
/home/AndrewDunstan/bf/root/HEAD/pgsql.2768/src/interfaces/ecpg/ecpglib/execute.c:979: undefined reference to
`_PGTYPEStimestamp_to_asc'
[...]

I wonder why the dlltool failure is not causing the build to fail
immediately?

-- 
Alvaro Herrera                  http://www.amazon.com/gp/registry/5ZYLFMCVHXC
"The Postgresql hackers have what I call a "NASA space shot" mentality.Quite refreshing in a world of "weekend drag
racer"developers."
 
(Scott Marlowe)