Re: New idea for patch tracking
От | Bruce Momjian |
---|---|
Тема | Re: New idea for patch tracking |
Дата | |
Msg-id | 200705051433.l45EXNj20626@momjian.us обсуждение исходный текст |
Ответ на | Re: New idea for patch tracking (Zdenek Kotala <Zdenek.Kotala@Sun.COM>) |
Список | pgsql-hackers |
OK, item modified to: <li>Passes all regression tests, and if needed, adds newones</li> --------------------------------------------------------------------------- Zdenek Kotala wrote: > I would like to add one point: > > Bruce Momjian wrote: > > > > > Patch committers check several things before applying a patch: > > > > 1) Follows the SQL standard or community agreed-upon behavior > > 2) Style merges seamlessly into the surrounding code > > 3) Written as simply and efficiently as possible > > 4) Uses the available PostgreSQL subsystems properly > > 5) Contains sufficient comments > > 6) Contains code that works on all supported operating systems > > 7) Has proper documentation > > 8) Passes all regression tests > > 8.5) Contains regression test(s) which covered performed changes > > > 9) Behaves as expected, even under unusual cirumstances > > 10) Contains no reliability risks > > 11) Does not overly complicate the source code > > 12) If performance-related, it should have a measureable performance benefit > > 13) Is of sufficient usefulness to the average PostgreSQL user > > 14) Follows existing PostgreSQL coding standards > > > > > Zdenek -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. +
В списке pgsql-hackers по дате отправления: