Re: Re: [HACKERS] [COMMITTERS] pgsql: Add GUC temp_tablespaces to provide a default location for

This has been saved for the 8.4 release:

    http://momjian.postgresql.org/cgi-bin/pgpatches_hold

---------------------------------------------------------------------------

Bruce Momjian wrote:
>
> OK, patch reverted.  Authors, would you please resubmit with fixes?
> Thanks.
>
> ---------------------------------------------------------------------------
>
> Tom Lane wrote:
> > momjian@postgresql.org (Bruce Momjian) writes:
> > > Add GUC temp_tablespaces to provide a default location for temporary
> > > objects.
> > > Jaime Casanova
> >
> > I hadn't looked at this patch before, but now that I have, it is
> > rather broken.
> >
> > In the first place, it makes no provision for RemovePgTempFiles() to
> > clean up leftover temp files that are in non-default places.
> >
> > In the second place, it's a serious violation of what little modularity
> > and layering we have for fd.c to be calling into commands/tablespace.c.
> > This is not merely cosmetic but has real consequences: one being that
> > it's now unsafe to call OpenTemporaryFile outside a transaction.
> >
> > Please revert until the submitter can come up with a better-designed
> > patch.
> >
> >             regards, tom lane
> >
> > ---------------------------(end of broadcast)---------------------------
> > TIP 4: Have you searched our list archives?
> >
> >                http://archives.postgresql.org
>
> --
>   Bruce Momjian  <bruce@momjian.us>          http://momjian.us
>   EnterpriseDB                               http://www.enterprisedb.com
>
>   + If your life is a hard drive, Christ can be your backup. +


>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: explain analyze is your friend

--
  Bruce Momjian  <bruce@momjian.us>          http://momjian.us
  EnterpriseDB                               http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +