Re: XML changes broke assert-enabled vcbuild

Peter Eisentraut wrote:
> Tom Lane wrote:
> > Magnus Hagander <magnus@hagander.net> writes:
> > > From what I can tell, this is because the Assert() puts code (the
> > > do {} loop) *before* the declaration of StringInfoData buf, which
> > > is not permitted.
> >
> > This will fail on every ANSI-C compiler, not just vc.  Please fix.
> 
> We seem to have very poor coverage of such compilers in the build farm, 
> it seems.  Is the vcbuild ready to support a regular build farm run 
> yet?
> 
> It turns out that gcc warns about it anyway.  Does anyone have some sort 
> of clever recipe to catch warnings more easily than by carefully 
> reading the make output or manually grepping build log files or 
> something?

Yes, I run /src/tools/pgtest, which shows the warning lines at the end,
after the regression tests are run.

--  Bruce Momjian  <bruce@momjian.us>          http://momjian.us EnterpriseDB
http://www.enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +