Re: Tricky bugs in concurrent index build

Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > What bothers me about what we have now is that we have optional keywords
> > before and after INDEX, rather than only between CREATE and INDEX.
> 
> Yeah, putting them both into that space seems consistent to me, and
> it will fix the problem of making an omitted index name look like
> a valid command.
> 
> I'm not sure I should be opening this can of worms, but do we want to
> use a different keyword than CONCURRENTLY to make it read better there?

The problem is that what the qualifier is doing is modifying the
operation itself, not the properties of the index to be created, like
UNIQUE, which modifies the index.  So the qualifier should be something
that modifies the CREATE, that is, an adverb (AFAIK).

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.