Re: [PATCHES] Custom variable class segmentation fault
От | Bruce Momjian |
---|---|
Тема | Re: [PATCHES] Custom variable class segmentation fault |
Дата | |
Msg-id | 200608160031.k7G0VKm24248@momjian.us обсуждение исходный текст |
Ответ на | Re: [PATCHES] Custom variable class segmentation fault (Tom Lane <tgl@sss.pgh.pa.us>) |
Список | pgsql-hackers |
Tom Lane wrote: > Peter Eisentraut <peter_e@gmx.net> writes: > > I merely said that the way the patch was presented, with significant > > code refactoring mixed in, I couldn't review it (as effectively as > > perhaps otherwise). FWIW, I believe that the general approach is > > sound, but I haven't actually "reviewed" the patch completely. > > Given the multiple problems already found, I feel quite uncomfortable > with putting it back in until another set of eyeballs has been over > it. Do you have time to do a full review anytime soon? I'm trying > to deal with all the other stuff in the queue, and so would prefer > not to spend my own time on it ... Peter, you also commented on an error message displayed, so I assume you did look it over somewhat. I agree it would be best for Peter to review it. -- Bruce Momjian bruce@momjian.us EnterpriseDB http://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. +
В списке pgsql-hackers по дате отправления: