Re: [PATCHES] Generic Monitoring Framework with DTrace patch

Robert Lor wrote:
> I've have attached a patch along with two new files.This patch should
> reflect what we discussed at the Summit. Please let me know if I miss
> anything.

I would prefer to drop the PG_ prefixes on PG_TRACE and pg_trace.h.  We 
know which software we're dealing with.

> 1) The current logic in src/backend/Makefile will only work for
> Solaris versions with DTrace, and Peter has offered to help fix this
> one.

We should probably move the probes file to a subdirectory.  Anyone know 
a good place?

Also, again, the pgsql prefix should be dropped.

> 2) Currently an environment variable called DTRACE_DATA_MODEL is used
> in src/backend/Makefile to tell the dtrace command whether to
> generate a 32 or 64 bit binary.  This may not be a reliable approach
> since a user can forget to set this variable. Perhaps adding a flag
> like DTRACEFLAGS to the configure script is a better approach.

Certainly doable, but will that be more reliable?  Can't we convince 
dtrace to create binaries for the host platform by default?

> 3)  When using --enable-depend, "gmake clean" removes all *.d files,

I'm working on renaming the dependency files.

-- 
Peter Eisentraut
http://developer.postgresql.org/~petere/