Re: Typo in ginxlog.c

On Thu, May 04, 2006 at 08:46:54AM +0100, Simon Riggs wrote:
> On Tue, 2006-05-02 at 15:01 -0400, Alvaro Herrera wrote:
> > Just noticed a typo in newly added ginxlog.c.  I don't have line
> > numbers, but in ginRedoSplit() it reads:
> > 
> >     PageSetLSN(rpage, lsn);
> >     PageSetTLI(lpage, ThisTimeLineID);
> >     MarkBufferDirty(rbuffer);
> > 
> >     PageSetLSN(lpage, lsn);
> >     PageSetTLI(lpage, ThisTimeLineID);
> >     MarkBufferDirty(lbuffer);
> > 
> > 
> > Notice the first call to PageSetTLI should be
> > 
> >     PageSetTLI(rpage, ThisTimeLineID);
> > 
> 
> Well spotted. We'd have not corrected that until someone's db failed.

It also begs the question of if there should be a function/macro that
handles those 3 steps...
-- 
Jim C. Nasby, Sr. Engineering Consultant      jnasby@pervasive.com
Pervasive Software      http://pervasive.com    work: 512-231-6117
vcard: http://jim.nasby.net/pervasive.vcf       cell: 512-569-9461