Re: Solaris ASM problem

Kris Jurka wrote:
>
>
> On Fri, 28 Apr 2006, Theo Schlossnagle wrote:
>
> > The file that uses the spinlocks:
> > /src/backend/storage/lmgr/s_lock.c
> >
> > can be compiled standalone with -DS_LOCK_TEST
> >
>
> To get the test to compile I had to link in tas.o as the attached patch
> shows.  Unfortunately this doesn't work for platforms that don't have a
> tas.o, bailing out with file not found.  Perhaps it's not important to fix
> this test, but I thought I'd mention it.

Fixed with the attached patch.  Thanks.

--
  Bruce Momjian   http://candle.pha.pa.us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +
Index: src/backend/storage/lmgr/Makefile
===================================================================
RCS file: /cvsroot/pgsql/src/backend/storage/lmgr/Makefile,v
retrieving revision 1.20
diff -c -c -r1.20 Makefile
*** src/backend/storage/lmgr/Makefile    7 Oct 2004 00:08:04 -0000    1.20
--- src/backend/storage/lmgr/Makefile    28 Apr 2006 22:51:26 -0000
***************
*** 19,27 ****
  SUBSYS.o: $(OBJS)
      $(LD) $(LDREL) $(LDOUT) SUBSYS.o $(OBJS)

  s_lock_test: s_lock.c $(top_builddir)/src/port/libpgport.a
      $(CC) $(CPPFLAGS) $(CFLAGS) -DS_LOCK_TEST=1 $(srcdir)/s_lock.c \
!         -L $(top_builddir)/src/port -lpgport -o s_lock_test

  check: s_lock_test
      ./s_lock_test
--- 19,31 ----
  SUBSYS.o: $(OBJS)
      $(LD) $(LDREL) $(LDOUT) SUBSYS.o $(OBJS)

+ ifdef TAS
+ TASPATH = $(top_builddir)/src/backend/port/tas.o
+ endif
+
  s_lock_test: s_lock.c $(top_builddir)/src/port/libpgport.a
      $(CC) $(CPPFLAGS) $(CFLAGS) -DS_LOCK_TEST=1 $(srcdir)/s_lock.c \
!         $(TASPATH) -L $(top_builddir)/src/port -lpgport -o s_lock_test

  check: s_lock_test
      ./s_lock_test