Re: pgsql: Use special gcc -W flags only if we are using

Tom Lane wrote:
> momjian@postgresql.org (Bruce Momjian) writes:
> > Use special gcc -W flags only if we are using gcc, not if we are using
> > the Intel compiler.
>
> I'm not entirely thrilled with this patch, because it disables not only
> the -W options but also -fno-strict-aliasing.  Are you sure the latter
> is not needed for ICC?

Peter asked for specific problems with the warnings, and the submitter
produced results.  I see no mention of -fno-strict-aliasing:

    http://archives.postgresql.org/pgsql-patches/2006-04/msg00002.php

However, the -f flag is outside the block he modified:

      # Disable strict-aliasing rules; needed for gcc 3.3+
      PGAC_PROG_CC_CFLAGS_OPT([-fno-strict-aliasing])

That flag is still used for both gcc and the intel compiler, and because
he tested the patch, I assume it works for both too.

--
  Bruce Momjian   http://candle.pha.pa.us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +