Re: restore to defaults values when commenting of variables

Tom Lane wrote:
> BERTHOULE Emmanuel <pgdev@manberth.homeip.net> writes:
> > with this patch, you can now restore default value with SIGHUP when
> > commenting an variable in postgresql.conf
>
> This seems pretty poorly thought out, in particular making PGC_S_SIGHUP
> >= PGC_S_OVERRIDE seems to me likely to break the interaction with other
> sources.  Doesn't that cause postgresql.conf to override per-user and
> per-database settings?  Why do you need the extra value at all ---
> isn't the correct logic just to reset entries with source PGC_S_FILE?
>
> Another problem is that if there's something wrong with the config file,
> this will cause all values previously read from the config file to
> revert to defaults, which seems less than robust to me.  You really
> shouldn't apply the reset until after the file has been parsed.

Is any progress being made on this patch to address the above concerns?

--
  Bruce Momjian   http://candle.pha.pa.us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +