Re: not checking value returned from palloc?

Alvaro Herrera wrote:
> Mark Dilger wrote:
> > Peter Eisentraut wrote:
> > >Mark Dilger wrote:
> > >
> > >>Looking through the postgresql source code, I notice that there are
> > >>many places were palloc is used but the return value is not checked
> > >>to see if it is null.
> > >
> > >palloc will throw an exception if it cannot fulfill the request.  Code 
> > >that checks the return value for null is in fact a waste.
> > 
> > Interesting.  So the patch should go the other way, and remove the checks 
> > that are currently in the code?
> 
> Yes, if you find any such place please submit a patch.

I see one in cash.c that I will remove.

--  Bruce Momjian   http://candle.pha.pa.us SRA OSS, Inc.   http://www.sraoss.com
 + If your life is a hard drive, Christ can be your backup. +