Re: psql tab completion enhancements

Поиск
Список
Период
Сортировка
От Joachim Wieland
Тема Re: psql tab completion enhancements
Дата
Msg-id 20060203202648.GA5103@mcknight.de
обсуждение исходный текст
Ответ на Re: psql tab completion enhancements  (Bruce Momjian <pgman@candle.pha.pa.us>)
Ответы Re: psql tab completion enhancements  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-patches
On Fri, Feb 03, 2006 at 01:59:19PM -0500, Bruce Momjian wrote:
> I will adjust this patch based on later feedback emails.

I have another version of the patch. Minor style errors are corrected in it.

As far as I can see, open items are:

- Should all the

    const char* foocompletion = { "BAR", "BAZ" };

  be changed to

    char* foocompletion = { "BAR", "BAZ" };

  (including all functions that deal with that and take const char*'s now)
  or should a cast be used only for the growable-list-case.


- is the simple list_add_item() algorithm sufficient for the psql use case
  or not?


I append the version of the patch that I think is the latest I have.


Joachim


Вложения

В списке pgsql-patches по дате отправления:

Предыдущее
От: Bruce Momjian
Дата:
Сообщение: Re: psql tab completion enhancements
Следующее
От: Tom Lane
Дата:
Сообщение: Re: psql tab completion enhancements