Re: stats for failed transactions (was Re: [GENERAL] VACUUM Question)

Tom Lane wrote:
> Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> > Tom Lane wrote:
> >> I think this is unquestionably
> >> a bug, at least for autovacuum's purposes --- though it might be OK
> >> for the original intent of the stats system, which was simply to track
> >> activity levels.
> >> 
> >> Any thoughts about how it ought to work?
> 
> > I don't remember exactly how it works -- I think the activity (insert,
> > update, delete) counters are kept separately from commit/rollback
> > status, right?  Maybe we should keep three separate counters: "current
> > transaction counters" and "counters for transactions that were
> > aborted/committed".  We only send the latter counts, and the former are
> > added to them when the transaction ends.
> 
> My question was at a higher level, actually: *what* should we be
> counting?

Oh, I see.  Do you think small incremental improvements to the stat
system will buy us much?  I think we should be thinking big here, i.e.
rewrite most stuff instead.  In the meantime, we should fix the minor
issues but not spend too much time on it; IMHO anyway.

I can devote some time to it starting from, say, mid february, which is
when I think I'm going to have more time to spend on community stuff.
(I've been spending the last couple of months on PL/php and internal
Command Prompt stuff.)

-- 
Alvaro Herrera                  http://www.amazon.com/gp/registry/5ZYLFMCVHXC
"XML!" Exclaimed C++.  "What are you doing here? You're not a programming
language."
"Tell that to the people who use me," said XML.